GT-2990 Localization Settings Box (Tools Layout)#4422
Conversation
tjohnson009
commented
May 8, 2026
tjohnson009
commented
- Add Surface box to end of tools layout for personalization
- Create and insert localizations settings box for tools and lessons pages; lessons WIP
|
Make sure to add a paparazzi test that shows the new UI you added |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #4422 +/- ##
===========================================
+ Coverage 51.99% 52.14% +0.15%
===========================================
Files 454 456 +2
Lines 12075 12135 +60
Branches 2092 2103 +11
===========================================
+ Hits 6278 6328 +50
- Misses 5181 5185 +4
- Partials 616 622 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| internal fun rememberPinLastItemBottomArrangement(): Arrangement.Vertical = remember { | ||
| object : Arrangement.Vertical { | ||
| override fun Density.arrange(totalSize: Int, sizes: IntArray, outPositions: IntArray) { | ||
| var currentOffset = 0 | ||
| sizes.forEachIndexed { index, size -> | ||
| if (index == sizes.lastIndex) { | ||
| outPositions[index] = maxOf(currentOffset, totalSize - size) | ||
| } else { | ||
| outPositions[index] = currentOffset | ||
| currentOffset += size | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
the reason I had suggested providing an items value to this was so that you could specify the number of items you wanted to pin to the bottom (0, 1, or some other amount). I'm going to pull this branch down and update the Arrangement to support doing that
There was a problem hiding this comment.
Okay, good to know. Claude suggested I remove it after some other changes. I didn't understand why it was there at the time either. I can see how adding the items property gives the composable greater use in other situations.
There was a problem hiding this comment.
it was one of those things that wasn't a fully fleshed out comment before leaving for a week
… imports and style declarations
Co-authored-by: Daniel Frett <frett@users.noreply.github.com>
…oBottomArrangement Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
frett
force-pushed
the
GT-2990-Localization-Settings-Box
branch
from
98ae0a7 to
089ff26
Compare
2 participants
